Backport Node 14 syntax to comply to minimum reqs #2321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug while running
twill:build
in a Node v8 environment.While updating our site to the latest version of Twill 2—2.13.0, we ran into a bug while running
twill:build
. I have all the composer packages and their dependencies updated and installed and I ranphp artisan twill:update
successfully. But I'm running into a bug when I runphp artisan twill:build
:The culprit is this line here that uses the nullish coalescing operator (
??
):I'm running node v8.17.0 and npm v6.13.4, as the Twill documentation states that npm 6.13 is the recommended version. But according to node.green the nullish coalescing operator was introduced in node v14
This PR refactors
vue.config.js
to not use the ?? operator.