Merge pull request #2039 from area17/bc-checker-2x

[2.x] BC checker.

.github/workflows/main.yml

@@ -7,6 +7,25 @@ on:
   pull_request:
 
 jobs:
+  roave-backwards-compatibility-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - name: Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: "8.1"
+      - name: Install dependencies
+        run: composer install
+      - name: Install checker
+        run: composer require roave/backward-compatibility-check --dev
+      - name: Require dep
+        run: composer require kalnoy/nestedset
+      - name: Check for BC breaks
+        run: vendor/bin/roave-backward-compatibility-check --format=github-actions --from=2.12.3 --install-development-dependencies
+
   test:
     runs-on: ${{ matrix.os }}
     strategy:

src/Repositories/ModuleRepository.php

@@ -163,10 +163,9 @@ public function getById($id, $with = [], $withCount = [])
      * @param string $column
      * @param array $orders
      * @param null $exceptId
-     * @param string $pluckby
      * @return \Illuminate\Support\Collection
      */
-    public function listAll($column = 'title', $orders = [], $exceptId = null, $pluckby = 'id')
+    public function listAll($column = 'title', $orders = [], $exceptId = null)
     {
         $query = $this->model->newQuery();
 
@@ -184,7 +183,7 @@ public function listAll($column = 'title', $orders = [], $exceptId = null, $pluc
             $query = $query->withTranslation();
         }
 
-        return $query->get()->pluck($column, $pluckby);
+        return $query->get()->pluck($column, 'id');
     }
 
     /**