Skip to content

Commit

Permalink
Merge branch '3.x' into fix-nested-repeaters
Browse files Browse the repository at this point in the history
  • Loading branch information
ifox authored Oct 14, 2024
2 parents a76cf23 + cc26b32 commit 27ccbb5
Show file tree
Hide file tree
Showing 62 changed files with 1,529 additions and 688 deletions.
43 changes: 16 additions & 27 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,25 +65,17 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
php: [8.3, 8.2, 8.1, 8.0]
laravel: [9.*, 10.*, 11.*]
php: [8.3, 8.2, 8.1]
laravel: [10.*, 11.*]
dbal: [3.*, 4.*]
exclude:
- laravel: 9.*
dbal: 4.*
- laravel: 10.*
dbal: 4.*
- laravel: 10.*
php: 8.0
- laravel: 11.*
php: 8.0
- laravel: 11.*
php: 8.1
- laravel: 11.*
dbal: 3.*
include:
- laravel: 9.*
testbench: 7.*
- laravel: 10.*
testbench: 8.*
- laravel: 11.*
Expand Down Expand Up @@ -128,15 +120,6 @@ jobs:
composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" "doctrine/dbal:${{ matrix.dbal }}" --no-interaction --no-update
composer install --prefer-dist --no-interaction --no-plugins
- name: Patch TestCase files for PHP < 8.1
run: |
if php -r 'exit(version_compare(PHP_VERSION, "8.1.0", "<") ? 0 : 1);'; then
for file in tests/integration/TestCase.php tests/Browser/BrowserTestCase.php; do
sed -i 's/protected function onNotSuccessfulTest(Throwable \$t): never/protected function onNotSuccessfulTest(Throwable \$t): void/' "$file";
echo "Patched $file for PHP < 8.1";
done
fi
- name: Setup Node.js
uses: actions/setup-node@v1
with:
Expand Down Expand Up @@ -164,11 +147,6 @@ jobs:
- name: Prepare Testbench Dusk
run: ./vendor/bin/testbench-dusk package:discover

- name: Set PHPUnit config for Laravel 9
if: matrix.laravel == '9.*'
run: |
cp phpunit-legacy.xml phpunit.xml
- name: Execute all tests
run: vendor/bin/phpunit --stop-on-error
env:
Expand All @@ -178,10 +156,21 @@ jobs:
with:
files: .github/clover.xml

- uses: actions/upload-artifact@v2
if: always()
- name: Replace asterisks in Laravel
run: echo "REPLACED_LARAVEL=${MATRIX_LARAVEL//\*/_}" >> $GITHUB_ENV
env:
MATRIX_LARAVEL: ${{ matrix.laravel }}

- name: Replace asterisks in DBAL
id: replace_dbal
run: echo "REPLACED_DBAL=${MATRIX_DBAL//\*/_}" >> $GITHUB_ENV
env:
MATRIX_DBAL: ${{ matrix.dbal }}

- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: screenshots
name: screenshots-${{ matrix.os }}-${{ matrix.php }}-${{ env.REPLACED_LARAVEL }}-${{ env.REPLACED_DBAL }}
path: |
tests/Browser/screenshots/
tests/Browser/console/
2 changes: 1 addition & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ If you are relying on Quill.js specifics (like css classes), use `'type' => 'qui
Previously `withVideo` was true by default, if you relied on this you have to update these media fields to
`'withVideo' => true`.

#### SVG's are now no longer passing thorough glide
#### SVG's are now no longer passing through glide

These are now rendered directly, you can change this by updating config `twill.glide.original_media_for_extensions` to an empty array `[]`

Expand Down
2 changes: 1 addition & 1 deletion config/twill.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

/*
|--------------------------------------------------------------------------
| Application strict url handeling
| Application strict url handling
|--------------------------------------------------------------------------
|
| Setting this value to true will enable strict domain handling.
Expand Down
25 changes: 0 additions & 25 deletions docs/content/1_docs/2_getting-started/3_configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,31 +79,6 @@ return [
];
```

Twill registers its own exception handler in all controllers. If you need to customize it (to report errors on a 3rd party service like Sentry or Rollbar for example), you can opt-out from it in your `config/twill.php` file:

```php
<?php

return [
'bind_exception_handler' => false,
];
```

And then extend it from your own `app/Exceptions/Handler.php` class:

```php
<?php

namespace App\Exceptions;

use A17\Twill\Exceptions\Handler as ExceptionHandler;
use Exception;
use Illuminate\Auth\AuthenticationException;

class Handler extends ExceptionHandler
...
```

If you would like to provide custom tables names, use the following configuration options:

```php
Expand Down
3 changes: 2 additions & 1 deletion docs/content/1_docs/3_modules/5_controllers.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ Below is a list of the methods and their purpose:
- **setModuleName**('`yourModuleName`'): Set the name of the module you are working with.
- **setFeatureField**('`fieldname`'): Set the field to use for featuring content.
- **setSearchColumns**(`['title', 'year']`): Set the columns to search in.
- **setSearchQuery**(`
fn (Builder $q, string $search) => $q->orWhereHas('profile', fn (Builder $q) => $q->where('first_name', 'like', "$search%")->orWhere('last_name', 'like', "$search%"))`): For finer controller over the search
- **setPermalinkBase**('`example`'): The static permalink base to your module. Defaults to `setModuleName` when empty.
- **setTitleColumnKey**('`title`'): Sets the field to use as title, defaults to `title`.
- **setModelName**('`Project`'): Usually not required, but in case customization is needed you can use this method to set
Expand Down Expand Up @@ -240,4 +242,3 @@ protected function formData($request)
return [];
}
```

4 changes: 2 additions & 2 deletions docs/content/1_docs/6_relations/03_one-to-many.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ One to Many is one of the simpler relations to set up so let's get started:

As with any relation we need to set up a database. In this example we are using our portfolio example where we will have multiple links on a project.

We will set up 2 models, one is a Project model, you can do this using `php artisan twill:module Project`
We will set up 2 models, one is a Project model, you can do this using `php artisan twill:make:module Project`

And afterwards a Link model: `php artisan twill:module Link`, As the Link model is used for our hasMany, we do not have to add it to the routes or navigation files, so you can ignore that suggestion.
And afterwards a Link model: `php artisan twill:make:module Link`, As the Link model is used for our hasMany, we do not have to add it to the routes or navigation files, so you can ignore that suggestion.

In the **Link** migration we add a column to hold the `project_id` that we are creating it from.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ return [
```

Now with this in place, you can go back to the block editor and add your first image block! But just as before, we have
to update the content of the preview file (`resources/views/site/blocks/text.blade.php`) so that we actually display
to update the content of the preview file (`resources/views/site/blocks/image.blade.php`) so that we actually display
the image!

```blade
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ npm install vue-numeric --save
in-store="value"
></a17-custom-number>
@unless($renderForBlocks || $renderForModal || (!isset($item->$name) && null == $formFieldsValue = getFormFieldsValue($form_fields, $name)))
@unless($renderForBlocks || $renderForModal || (!isset($item->$name) && is_null($formFieldsValue = getFormFieldsValue($form_fields, $name))))
@push('vuexStore')
window['{{ config('twill.js_namespace') }}'].STORE.form.fields.push({
name: '{{ $name }}',
Expand Down
2 changes: 1 addition & 1 deletion frontend/js/components/Previewer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
name: 'preview-tablet-v'
},
{
size: 320,
size: 390,
name: 'preview-mobile'
}
]
Expand Down
4 changes: 4 additions & 0 deletions frontend/scss/vendor/_vselect.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ $multiSelectHeight: 45px;
}

.vs__dropdown-menu {
// make sure the content expand to the longest option
--vs-dropdown-min-width: fit-content;
padding:15px 0;
border-top:1px solid $color__border--light;
box-shadow: 0px 1px 3.5px 0px rgba(0, 0, 0, 0.30);
Expand Down Expand Up @@ -167,6 +169,7 @@ $multiSelectHeight: 45px;
padding:0 0 0 15px;
margin:0;
color:$color__f--text;

button {
position: absolute;
background-color: $color__black--35;
Expand Down Expand Up @@ -408,6 +411,7 @@ $multiSelectHeight: 45px;
.vs__deselect {
top:2px;
right:2px;
transform: none;
background-color:transparent;
background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIxMCIgaGVpZ2h0PSIxMCIgdmlld0JveD0iMCAwIDEwIDEwIj48cGF0aCBmaWxsPSJub25lIiBzdHJva2U9IiNhNmE2YTYiIGQ9Ik0yIDJsNiA2TTggMkwyIDgiLz48L3N2Zz4=);
color:$color__fborder--hover;
Expand Down
11 changes: 11 additions & 0 deletions lang/de/lang.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
'reset-password' => 'Passwort zurücksetzen',
'reset-send' => 'Link zum Zurücksetzen des Passworts senden',
'verify-login' => 'Anmeldung bestätigen',
'auth-causer' => 'Authentifikation',
],
'buckets' => [
'intro' => 'Was würden Sie heute gerne vorstellen?',
Expand Down Expand Up @@ -56,6 +57,9 @@
'unfeatured' => 'Hervorhebung aufgehoben',
'restored' => 'Wiederhergestellt',
'deleted' => 'Gelöscht',
'login' => 'Anmeldung',
'logout' => 'Abmeldung',
'duplicated' => 'Dupliziert',
],
'activity-row' => [
'edit' => 'Bearbeiten',
Expand Down Expand Up @@ -145,6 +149,7 @@
],
],
'editor' => 'Editor',
'options' => 'Optionen',
],
'lang-manager' => [
'published' => 'Veröffentlicht',
Expand Down Expand Up @@ -196,6 +201,7 @@
'mine' => 'Meine',
'published' => 'Veröffentlicht',
'trash' => 'Papierkorb',
'not-set' => 'Ohne Wert',
],
'filters' => [
'all-label' => 'Alle :label',
Expand Down Expand Up @@ -407,6 +413,11 @@
'scheduled' => 'Geplant',
'expired' => 'Abgelaufen',
'unsaved-changes' => 'Es gibt nicht gespeicherte Änderungen',
'draft-revision' => 'Als Entwurfs-Revision abspeichern',
'draft-revision-close' => 'Als Entwurfs-Revision abspeichern und schließen',
'draft-revision-new' => 'Als Entwurfs-Revision abspeichern und weiteren erstellen',
'draft-revisions-available' => 'Sie betrachten die aktuell veröffentlichte Version des Inhalts. Es gibt neuere Entwurfs-Revisionen.',
'editing-draft-revision' => 'Sie bearbeiten aktuell eine Entwurfs-Revision dieses Inhalts. Speichern Sie die Änderungen oder Veröffentlichen Sie diese.',
],
'select' => [
'empty-text' => 'Leider keine passenden Optionen gefunden',
Expand Down
1 change: 1 addition & 0 deletions lang/en/lang.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
'deleted' => 'Deleted',
'login' => 'Login action',
'logout' => 'Logout action',
'duplicated' => 'Duplicated',
],
'activity-row' => [
'edit' => 'Edit',
Expand Down
Loading

0 comments on commit 27ccbb5

Please sign in to comment.