Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ATtiny1614 #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kr15h
Copy link

@kr15h kr15h commented Aug 20, 2020

One of our Fab Academy students wanted to use the lib with ATtiny1614 which is one of the new AVR-1 boards. They use different way of handling the pins when used via the megaTinyCore library. I added the following changes to Sd2PinMap.h file.

  • New pin map struct to support new AVR-1 naming
  • ATtiny1614 pin mapping based on megaTinyCore
  • New helper functions for reading/writing pins compatible with AVR-1 naming

Tested. Works. More AVR-1 chips to come.

@TravisBuddy
Copy link

Travis tests have failed

Hey @kr15h,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5da479e0-e315-11ea-bb85-f7bf5149087f

@kr15h
Copy link
Author

kr15h commented Jan 14, 2021

Looks like there is a formatting issue. I will look into it. Is there a formatting manual somewhere?

@per1234
Copy link
Contributor

per1234 commented Jan 14, 2021

Hi @kr15h. Thanks for your care for the CI status. You're right that there is a formatting issue, but this issue was introduced by the person who changed the code before you submitted this PR (85dbcca). So you don't need to worry about fixing the formatting.

@kr15h
Copy link
Author

kr15h commented Jan 14, 2021

So should I rebase on top of the current HEAD?

@per1234
Copy link
Contributor

per1234 commented Jan 14, 2021

You're welcome to do so if you like, but it's not mandatory.

@per1234 per1234 added the type: enhancement Proposed improvement label Jan 14, 2021
@kr15h
Copy link
Author

kr15h commented Jan 15, 2021

We are using the library for the Fab Academy course and it would be nice to have the ATtiny1614 and other 0,1 chips available from the mainline. What do you need me to do for this to become merged?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SpenceKonde
Copy link

Why does this need to be made so complicated, People have reported success with just i submitted in #110

@kr15h
Copy link
Author

kr15h commented Jan 17, 2022

That was the only way I could figure at the time. Thanks @SpenceKonde for #110

@per1234 per1234 added the topic: code Related to content of the project itself label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants