Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading spaces in the filename #80

Closed
wants to merge 1 commit into from

Conversation

shawayush
Copy link

https://docs.microsoft.com/en-us/windows/win32/intl/character-sets-used-in-file-names

According to the article above though Windows now supports NTFS format, the SD card still uses FAT format. Some character was added, I hope this solves the issue #3

@per1234
Copy link
Contributor

per1234 commented Mar 30, 2020

Unless I misunderstand, the only thing this PR does is disallow exclamation points (ASCII code 0x21) in filenames. If that's really what you intend to propose, then you should make that very clear in the commit/PR message, as well as providing your reasoning for this change. "Some characters are added" is not an accurate description.

#3 is about allowing extended ASCII and spaces in filenames. This PR does not do any of that, so definitely should not be considered to solve #3.

@shawayush
Copy link
Author

okay, shall I close this PR then?

@shawayush shawayush closed this Mar 30, 2020
@per1234
Copy link
Contributor

per1234 commented Mar 30, 2020

If you think this is a change that needs to be made, then you should leave it open, but you need to explain the purpose.

@shawayush
Copy link
Author

A lot of file names have spaces and it would be great if they could be recognized easily

@shawayush shawayush reopened this Mar 30, 2020
@per1234
Copy link
Contributor

per1234 commented Mar 30, 2020

Please edit the commit and PR messages to make it clear that is the purpose.

Have you tested to be sure that this change causes the library to allow spaces in file names?

@shawayush shawayush changed the title Some characters are added Reading spaces in the filename Mar 30, 2020
@shawayush
Copy link
Author

Hey sorry, This patch doesn't solve anything, I had an NTFS format Sd card, which was working after this patch, but I realized that most of the SD card is FAT format, which doesn't support this patch. I will close this PR, I really sorry to waste your time, I promise, not to repeat it again!

@shawayush shawayush closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants