Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnnotatedReferenceAssemblyVersion to fix build #352

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

canro91
Copy link
Contributor

@canro91 canro91 commented Jul 2, 2024

By adding a AnnotatedReferenceAssemblyVersion node, it fixes the error: "RA0001 There is more than one PackageDownload of Microsoft.NETCore.App.Ref"

And to fix the error: "error NETSDK1127: The targeting pack Microsoft.NETCore.App is not installed. Please restore and try again" on the GitHub actions, it only "injects" the TunnelVision assembly when targeting .netstandard2.0.

I found this workaround, after sneaking into other repos (for example: Spectre.Console.csproj). Not quite sure if this an official solution.

Addresses #336

Copy link

github-actions bot commented Jul 3, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.GuardClauses 49% 93% 403
Summary 49% (295 / 597) 93% (230 / 246) 403

@ardalis ardalis merged commit c58d4ea into ardalis:main Jul 8, 2024
1 check passed
@ardalis
Copy link
Owner

ardalis commented Jul 8, 2024

Awesome, thanks!

@ardalis ardalis mentioned this pull request Jul 8, 2024
@canro91 canro91 deleted the fix-build branch July 9, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants