feat(transport): Make SvelteKit adapter deployable on Netlify Edge Functions #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
blaine-arcjet
commented
Nov 5, 2024
blaine-arcjet
commented
Nov 5, 2024
blaine-arcjet
commented
Nov 5, 2024
e-moran
requested changes
Nov 5, 2024
|
|
||
| return { | ||
| async unary( | ||
| ...args: [any, any, any, any, any, any, any] |
There was a problem hiding this comment.
Can we get some concrete types for these?
There was a problem hiding this comment.
I believe these types come from connectrpc directly and we don't want to add another dependency to get the types. There may be a way to use utility types to pull them out but I'm not sure.
| return client.unary(...args); | ||
| }, | ||
| async stream( | ||
| ...args: [any, any, any, any, any, any, any] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify Edge Funcitons run on a super old version of Deno that fails on some
node:*imports. This is a really nasty workaround that allows Arcjet-protected SvelteKit apps to be deployed there.