Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

equal object support #262

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

equal object support #262

wants to merge 4 commits into from
+47 −0

Conversation

pnowak
Copy link

@pnowak pnowak commented Mar 1, 2017

No description provided.

ironmaniiith
ironmaniiith reviewed May 24, 2018
View reviewed changes
is.js Outdated
return true;
}

if (length !== Object.keys(other)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. Maybe you wanted to write length !== Object.keys(other).length

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, in the next commit 382f695 I changed it.

@evdama
Copy link

evdama commented Mar 18, 2022

I'd like to add this to https://github.com/evdama/is-it-check
Would you mind sending a PR quickly? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironmaniiith ironmaniiith ironmaniiith left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pnowak @evdama @ironmaniiith @jdalton