Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH][TEST] Move logic for file checking and add tests in center_nifti #1421

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Jan 28, 2025

In this PR :

  • All the logic for file checking is moved in the private function for centering files
  • Unit tests are added
  • File overwriting was renewed :
    • Before : it copied only files at the root level (ex : description json) but not nifti files nested in folders if both directories had folders with same names. That is a bit misleading because it looks like it will preserve what is inside the BIDS input and actually... does not.
    • Now : will completely remove files inside the output folder.
      → This is a bit radical and could be changed for a solution that iteratively checks files from both folders in a follow-up PR

In another PR : non-regressions tests should look inside nifti files and check option for overwriting

@AliceJoubert AliceJoubert marked this pull request as ready for review January 30, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant