Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-3630): Update radio card and checkbox card to accept children property and render when selected/checked #310

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

shan8851
Copy link
Contributor

@shan8851 shan8851 commented Oct 11, 2024

Description

Update radio card and checkbox card to accept children property and render when selected/checked

Task: APP-3630

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @shan8851!

CHANGELOG.md Outdated Show resolved Hide resolved
src/core/components/forms/radioCard/radioCard.tsx Outdated Show resolved Hide resolved
src/core/components/forms/radioCard/radioCard.test.tsx Outdated Show resolved Hide resolved
src/core/components/forms/radioCard/radioCard.stories.tsx Outdated Show resolved Hide resolved
@cgero-eth cgero-eth merged commit 179cf12 into main Oct 14, 2024
4 checks passed
@cgero-eth cgero-eth deleted the feat/APP-3630-gov-kit branch October 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants