Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2296 env example #921

Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat: APP-2296 env example #921

merged 1 commit into from
Jul 14, 2023

Conversation

babarella
Copy link
Contributor

@babarella babarella commented Jul 13, 2023 •
edited by jira bot
Loading

Description

As an outside Dev forking the App I want to easily see which env variables I should add to make the App work

Task: APP-2296

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@babarella babarella requested a review from jamesej July 13, 2023 15:28
jamesej
jamesej approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@jamesej jamesej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@babarella babarella merged commit 06e961a into develop Jul 14, 2023
4 of 5 checks passed
@babarella babarella deleted the f/APP-2296-env-example branch July 14, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesej jamesej jamesej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babarella @jamesej