Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-2253 removed scroll from modals and bottom sheet components #917

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

babarella
Copy link
Contributor

@babarella babarella commented Jul 11, 2023

Description

When popup modals are displayed, background page is still scrollable.

Task: APP-2253

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@babarella babarella requested a review from a team July 11, 2023 21:08
Copy link
Contributor

@RakeshUP RakeshUP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to test this one. It could be due to the useEffect block that I've mentioned in the comment. Seems like two useEffects's are racing to set overflow on the html tag

@Fabricevladimir
Copy link
Contributor

@babarella, Can you take a look at Radix UI? We're using their headless Dialog component, which should by default render the content underneath inert/unscrollable

@babarella
Copy link
Contributor Author

@babarella, Can you take a look at Radix UI? We're using their headless Dialog component, which should by default render the content underneath inert/unscrollable

Applied radix overlay for modals, thanks for suggestion.

@babarella babarella requested a review from RakeshUP July 12, 2023 19:00
Copy link
Contributor

@RakeshUP RakeshUP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@babarella babarella merged commit a7d1179 into develop Jul 13, 2023
4 checks passed
@babarella babarella deleted the fix/APP-2253-modals-scroll branch July 13, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants