Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update the bigint encoder error - APP-2257 #913

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix: Update the bigint encoder error - APP-2257 #913

merged 1 commit into from
Jul 13, 2023

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented Jul 10, 2023 •
edited
Loading

Description

Task: APP-2257

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@github-actions
Copy link

WebApp IPFS Hash: Qmad5S8aS6kvZVmtuQvgfWW9fb7r8QCavYCuqU9LUqiZcN
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/Qmad5S8aS6kvZVmtuQvgfWW9fb7r8QCavYCuqU9LUqiZcN/

@sepehr2github sepehr2github marked this pull request as ready for review July 12, 2023 08:42
@sepehr2github sepehr2github changed the title Fix: Cannot Execute Max Token Balance Withdrawal with Many Decimals - APP-2257 Fix: Update the bigint encoder error - APP-2257 Jul 12, 2023
Fabricevladimir
Fabricevladimir approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sepehr. Hopefully that solves our issue

packages/web-app/src/context/createProposal.tsx Show resolved Hide resolved
@sepehr2github sepehr2github merged commit 20ddef1 into develop Jul 13, 2023
5 of 6 checks passed
@sepehr2github sepehr2github deleted the fix/app-2257 branch July 13, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir approved these changes

Assignees
No one assigned
Labels
preview web-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sepehr2github @Fabricevladimir