Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-2621): Proposal is missing Exact Expiry Data/ Time for Multisig DAO #1391

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Jul 25, 2024

Compare before and after in the images below.

Also checked several other Multisig and Token Based DAOs. End duration all looks good on those as well.

Before (also see here)
image

After (also see here)
image

Task: APP-2621

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title fix: APP-2621 - Multisig DAO - Proposal is missing Exact Expiry Data/ Time fix(APP-2621): Proposal is missing Exact Expiry Data/ Time for Multisig DAO Jul 25, 2024
Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Barukimang!

@cgero-eth cgero-eth merged commit 5fd18e9 into develop Jul 25, 2024
2 checks passed
@cgero-eth cgero-eth deleted the fix/app-2621-expiry-time-multisig-proposal branch July 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants