Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(APP-3261): Truncate long link descriptions dashboard #1381

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix(APP-3261): Truncate long link descriptions dashboard #1381

merged 3 commits into from
Jul 9, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Jul 5, 2024 •
edited by jira bot
Loading

Dashboard UI fix, bringing default displayed shown back from 3 to 2, see BEFORE and AFTER in the images below:

BEFORE
image

AFTER
image

Task: APP-3261

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@Barukimang Barukimang requested review from evanaronson and cgero-eth and removed request for evanaronson July 5, 2024 11:22
cgero-eth
cgero-eth approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Barukimang!

@cgero-eth cgero-eth merged commit aed05ff into develop Jul 9, 2024
3 checks passed
@cgero-eth cgero-eth deleted the fix/app-3261-long-link branch July 9, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barukimang @cgero-eth