Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APP-2330 csv modal closing issue #1011

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix: APP-2330 csv modal closing issue #1011

merged 2 commits into from
Aug 29, 2023

Conversation

babarella
Copy link
Contributor

@babarella babarella commented Aug 29, 2023 •
edited by jira bot
Loading

Description

Csv modal closing issue mentioned in QA feedback.

Task: APP-2330

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@babarella babarella requested a review from a team August 29, 2023 00:04
sepehr2github
sepehr2github approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@sepehr2github sepehr2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@babarella babarella merged commit daad363 into develop Aug 29, 2023
3 checks passed
@babarella babarella deleted the fix/APP-2330-csv-modal-closing-issue branch August 29, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepehr2github sepehr2github sepehr2github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babarella @sepehr2github