fix(APP-3384): Correctly identify OSx updates as latest version (#1382)

aragon · Jul 8, 2024 · f94c066 · f94c066
1 parent a9ec745
commit f94c066
Showing 1 changed file with 11 additions and 23 deletions.
diff --git a/src/context/update.tsx b/src/context/update.tsx
@@ -169,30 +169,18 @@ const UpdateProvider: React.FC<{children: ReactElement}> = ({children}) => {
   useEffect(() => {
     if (versions) {
       const OSXVersions = new Map();
+      const versionKeys = Object.keys(SupportedVersions);
 
-      Object.keys(SupportedVersions).forEach(key => {
-        if (
-          compareVersions(
-            SupportedVersions[key as keyof typeof SupportedVersions],
-            versions.join('.')
-          ) === 1
-        ) {
-          OSXVersions.set(
-            SupportedVersions[key as keyof typeof SupportedVersions],
-            {
-              version: SupportedVersions[
-                key as keyof typeof SupportedVersions
-              ] as string,
-              ...(key === 'LATEST' && {isLatest: true}),
-            } as OSX
-          );
-
-          if (key === 'LATEST') {
-            setValue('osSelectedVersion', {
-              version: SupportedVersions[
-                key as keyof typeof SupportedVersions
-              ] as string,
-            });
+      versionKeys.forEach((key, index) => {
+        const version =
+          SupportedVersions[key as keyof typeof SupportedVersions];
+        const isLatest = index === versionKeys.length - 1;
+
+        if (compareVersions(version, versions.join('.')) === 1) {
+          OSXVersions.set(version, {version, isLatest});
+
+          if (isLatest) {
+            setValue('osSelectedVersion', {version});
           }
         }
       });