Correct issue introduced in commit ee6a4f5 (related to #343) #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
moosa-nasir
approved these changes
Apr 26, 2024
|
This repo's standards need to be increased. This PR should have failed via an automated test. Tons of action's users just wasted time on this mistake. |
aitrics-ray
reviewed
Apr 26, 2024
| @@ -195,7 +195,7 @@ if [ "${format}" == "sarif" ] && [ "${limitSeveritiesForSARIF}" != "true" ]; the | |||
| trivy --quiet ${scanType} --format sarif --output ${output} $SARIF_ARGS ${artifactRef} | |||
| elif [ $trivyConfig ]; then | |||
| echo "Running Trivy with trivy.yaml config from: " $trivyConfig | |||
| trivy --config $trivyConfig ${scanType} ${ARGS}" ${artifactRef} | |||
| trivy --config $trivyConfig ${scanType} ${ARGS} ${artifactRef} | |||
There was a problem hiding this comment.
While we're at it, it'd be nice to meet conventions.
Suggested change
| trivy --config $trivyConfig ${scanType} ${ARGS} ${artifactRef} | |
| echo "Running Trivy with trivy.yaml config from: ${trivyConfig}" | |
| trivy --config "${trivyConfig}" "${scanType}" "${ARGS}" "${artifactRef}" |
FYI
https://google.github.io/styleguide/shellguide.html#s5.6-variable-expansion
There was a problem hiding this comment.
Should be "${trivyConfig}" "${scanType}" "${ARGS}" "${artifactRef}" unless ARGS really needs to be unquoted.
|
@nicolargo I think you need to sign the CLA |
I do... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the " typo.