Bpf inner maps #4460
Closed
Bpf inner maps #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove bpfInnerMaps from the policies struct as it was only used within the updateBPF function and make it a local variable within updateBPF. This change improves code organization by keeping BPF-related logic separate from policies logic, reflecting a clearer structure in the codebase.
The `policyManager.UpdateBPF` function was being called twice during Tracee initialization. This change removes the redundant call in `initBPF`, simplifying the initialization logic. The unnecessary `updateProcTree` and `createNewMaps` parameters were also removed from `policyManager.UpdateBPF`. New maps are now always created implicitly, simplifying the map update process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Refactor: Remove redundant policyManager.UpdateBPF call in initBPF
The
policyManager.UpdateBPFfunction was being called twice during Tracee initialization. This change removes the redundant call ininitBPF, simplifying the initialization logic.The unnecessary
updateProcTreeandcreateNewMapsparameters were also removed frompolicyManager.UpdateBPF. New maps are now always created implicitly, simplifying the map update process.Refactor: Move bpfInnerMaps to local scope in updateBPF
Remove bpfInnerMaps from the policies struct as it was only used within the updateBPF function and make it a local variable within updateBPF.
This change improves code organization by keeping BPF-related logic separate from policies logic, reflecting a clearer structure in the codebase.
2. Explain how to test it
3. Other comments