Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release tarball static binaries & make daily building faster #4444

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Dec 18, 2024

Close: #4154
Close: #4443

1. Explain what the PR does

1517687 chore(ci): use new make snapshot rule
7e3eab7 chore(builder): version format & quicker snapshot
feca8a5 fix(builder): avoid static binary clobbering

1517687 chore(ci): use new make snapshot rule

This also removes INSTANCE_TYPE from the snapshot workflow, as it is
expected to be not so resource intensive now.

7e3eab7 chore(builder): version format & quicker snapshot

This changes the version format (details on #4154).

Also, this makes the snapshot (dev daily) building quicker by not
embedding the BTF files in the tracee binaries.

As daily images are not meant for production, this should not be a
problem, also considering that the majority of the contributors are
running latest kernels.

2. Explain how to test it

make -f builder/Makefile.release snapshot to quickly get a tracee:dev image (without BTF embedding).
make -f builder/Makefile.release release RELEASE_GITHUB=0 to get a tracee:latest image.

After check versions:

docker run --name tracee -it --rm --pid=host --cgroupns=host --privileged -v /etc/os-release:/etc/os-release-host:ro -v /var/run:/var/run:ro tracee:dev version
Tracee version: fix-release-building-b56ee730c
docker run --name tracee -it --rm --pid=host --cgroupns=host --privileged -v /etc/os-release:/etc/os-release-host:ro -v /var/run:/var/run:ro tracee:latest version
Tracee version: v0.22.0

Now, when working on your branches, you'll get a crystal binary version.

make tracee
./dist/tracee version
Tracee version: 4154-4443-release-building-1517687da

3. Other comments

This changes the version format (details on aquasecurity#4154).

Also, this makes the snapshot (dev daily) building quicker by not
embedding the BTF files in the tracee binaries.

As daily images are not meant for production, this should not be a
problem, also considering that the majority of the contributors are
running latest kernels.
This also removes INSTANCE_TYPE from the snapshot workflow, as it is
expected to be not so resource intensive now.
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
Copy link
Member Author

geyslan commented Dec 18, 2024

/fast-forward

This comment was marked as resolved.

@geyslan geyslan merged commit 7e0d70e into aquasecurity:main Dec 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static release artefacts are being clobbered Change version format (snapshots and main branch)
2 participants