-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ingest api 0.12.0 #143
Conversation
Co-authored-by: Harshal Sheth <[email protected]>
…8760) Co-authored-by: Tamas Nemeth <[email protected]>
…atahub-project#8357) Co-authored-by: cccs-Dustin <[email protected]> Co-authored-by: Fokko Driesprong <[email protected]> Co-authored-by: Andrew Sikowitz <[email protected]>
Co-authored-by: Hendrik Richert <[email protected]> Co-authored-by: RyanHolstien <[email protected]>
…ub-project#8672) Co-authored-by: Aseem Bansal <[email protected]> Co-authored-by: Indy Prentice <[email protected]>
…atahub-project#8154) Co-authored-by: Dominik Schüssele <[email protected]> Co-authored-by: Andrew Sikowitz <[email protected]>
…nnotations (datahub-project#8779) Co-authored-by: Harshal Sheth <[email protected]>
Co-authored-by: Tamas Nemeth <[email protected]>
Co-authored-by: John Joyce <[email protected]>
…-impl:checkRestModel'
token: ${{ secrets.CODECOV_TOKEN }} | ||
directory: . | ||
fail_ci_if_error: false | ||
flags: airflow-${{ matrix.python-version }}-${{ matrix.extraPythonRequirement }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
property "extrapythonrequirement" is not defined in object type {extra_pip_extras: string; extra_pip_requirements: string; python-version: number} [expression]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute DataHub Ingestion (Base) Tag | ||
id: tag | ||
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:120: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute DataHub Ingestion (Base-Slim) Tag | ||
id: tag | ||
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:130: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute DataHub Ingestion (Base-Full) Tag | ||
id: tag | ||
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute Tag | ||
id: tag | ||
run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:184: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute Tag (Full) | ||
id: tag | ||
run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:174: Double quote to prevent globbing and word splitting [shellcheck]
tried to cheapskate and just pip install acryl-datahub, cos mostly we just need to call the existing datahub types, but it doesnt work cos of the UnknownClassType. |
hmm. ingestion image have the unknowntype class. now to figure out how to make ingest-api do the same. |
outputs: | ||
image_tag: ${{ steps.docker_meta.outputs.tags }} | ||
image_name: ${{ env.INGEST_API_IMAGE }} | ||
tag: ${{ steps.tag.outputs.tag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
property "tag" is not defined in object type {filter: {conclusion: string; outcome: string; outputs: object}} [expression]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute Tag | ||
id: tag | ||
run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true' || steps.filter.outputs.ingest-api == 'true' ) && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:230: Double quote to prevent globbing and word splitting [shellcheck]
added the code in pr142 |
Checklist