misc docker fixes #125
misc docker fixes #125
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| publish: ${{ needs.setup.outputs.publish }} | ||
| context: . | ||
| file: ./docker/datahub-ingestion-base/Dockerfile | ||
| platforms: linux/amd64,linux/arm64/v8 | ||
| - name: Compute DataHub Ingestion (Base-Slim) Tag | ||
| id: tag | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.slim_tag || 'head' }}" >> $GITHUB_OUTPUT | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_slim_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]
| publish: ${{ needs.setup.outputs.publish }} | ||
| context: . | ||
| file: ./docker/datahub-ingestion-base/Dockerfile | ||
| platforms: linux/amd64,linux/arm64/v8 | ||
| - name: Compute DataHub Ingestion (Base-Full) Tag | ||
| id: tag | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.full_tag || 'head' }}" >> $GITHUB_OUTPUT | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]
| @@ -596,7 +592,7 @@ jobs: | |||
| platforms: linux/amd64,linux/arm64/v8 | |||
| - name: Compute Tag | |||
| id: tag | |||
| run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.slim_tag || 'head' }}" >> $GITHUB_OUTPUT | |||
| run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.unique_slim_tag || 'head' }}" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:179: Double quote to prevent globbing and word splitting [shellcheck]
| @@ -676,7 +672,7 @@ jobs: | |||
| platforms: linux/amd64,linux/arm64/v8 | |||
| - name: Compute Tag (Full) | |||
| id: tag | |||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.full_tag || 'head' }}" >> $GITHUB_OUTPUT | |||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]
Checklist