feat(datahub-ingestion): refactor datahub ingestion slim images (#8515) #122
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| platforms: linux/amd64,linux/arm64/v8 | ||
| - name: Compute DataHub Ingestion (Base) Tag | ||
| id: tag | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:113: Double quote to prevent globbing and word splitting [shellcheck]
| platforms: linux/amd64,linux/arm64/v8 | ||
| - name: Compute DataHub Ingestion (Base-Slim) Tag | ||
| id: tag | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.slim_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck]
| platforms: linux/amd64,linux/arm64/v8 | ||
| - name: Compute DataHub Ingestion (Base-Full) Tag | ||
| id: tag | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.full_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck]
| platforms: linux/amd64,linux/arm64/v8 | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.slim_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:172: Double quote to prevent globbing and word splitting [shellcheck]
| uses: ishworkh/docker-image-artifact-download@v1 | ||
| if: ${{ needs.setup.outputs.publish != 'true' }} | ||
| with: | ||
| image: ${{ env.DATAHUB_INGESTION_IMAGE }}:${{ needs.datahub_ingestion_slim_build.outputs.slim_tag }} |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
property "slim_tag" is not defined in object type {tag: string} [expression]
| env: | ||
| TRIVY_OFFLINE_SCAN: true | ||
| with: | ||
| image-ref: ${{ env.DATAHUB_INGESTION_IMAGE }}:${{ needs.datahub_ingestion_slim_build.outputs.slim_tag }} |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
property "slim_tag" is not defined in object type {tag: string} [expression]
| platforms: linux/amd64,linux/arm64/v8 | ||
| - name: Compute Tag (Full) | ||
| id: tag | ||
| run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.full_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck]
| uses: ishworkh/docker-image-artifact-download@v1 | ||
| if: ${{ needs.setup.outputs.publish != 'true' }} | ||
| with: | ||
| image: ${{ env.DATAHUB_INGESTION_IMAGE }}:${{ needs.datahub_ingestion_full_build.outputs.full_tag }} |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
property "full_tag" is not defined in object type {tag: string} [expression]
| env: | ||
| TRIVY_OFFLINE_SCAN: true | ||
| with: | ||
| image-ref: ${{ env.DATAHUB_INGESTION_IMAGE }}:${{ needs.datahub_ingestion_full_build.outputs.full_tag }} |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
property "full_tag" is not defined in object type {tag: string} [expression]
|
lint failures were expected. It was fixed by the subsequent PR. |
Checklist