Improve error message in AvroAliasTest

it gives the reason of schema incompatibility when the schema is expected to be compatible. It can help investigation on FasterXML#167 Signed-off-by: Aurélien Pupier <[email protected]>
apupier · Jan 5, 2024 · f8be18b · f8be18b
1 parent 23f40d9
commit f8be18b
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/...rc/test/java/com/fasterxml/jackson/dataformat/avro/interop/annotations/AvroAliasTest.java b/...rc/test/java/com/fasterxml/jackson/dataformat/avro/interop/annotations/AvroAliasTest.java
@@ -66,7 +66,7 @@ public void testAliasedRecordForwardsCompatible() throws IOException {
         SchemaCompatibility.SchemaPairCompatibility compatibility =
             SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
         //
-        assertThat(compatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
+        checkSchemaIsCompatible(compatibility);
     }
 
     @Test
@@ -88,7 +88,7 @@ public void testAliasedRecordForwardsCompatibleSameNamespace() throws IOExceptio
         SchemaCompatibility.SchemaPairCompatibility compatibility =
             SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
         //
-        assertThat(compatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
+        checkSchemaIsCompatible(compatibility);
     }
 
     @Test
@@ -110,7 +110,7 @@ public void testAliasedEnumForwardsCompatible() throws IOException {
         SchemaCompatibility.SchemaPairCompatibility compatibility =
             SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
         //
-        assertThat(compatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
+        checkSchemaIsCompatible(compatibility);
     }
 
     @Test
@@ -134,8 +134,14 @@ public void testAliasedEnumForwardsAndBackwardsCompatible() throws IOException {
         SchemaCompatibility.SchemaPairCompatibility forwardsCompatibility =
             SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
         //
-        assertThat(backwardsCompatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
-        assertThat(forwardsCompatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
+        checkSchemaIsCompatible(backwardsCompatibility);
+        checkSchemaIsCompatible(forwardsCompatibility);
+    }
+
+    private void checkSchemaIsCompatible(SchemaCompatibility.SchemaPairCompatibility compatibility) {
+        assertThat(compatibility.getType())
+            .withFailMessage("Expected schema to be compatible but was not. Reason:\n%s", compatibility.getDescription())
+            .isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
     }
 
 }