Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Debugged PACKAGE.html problem #697 #803

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thecloudcode
Copy link

@thecloudcode thecloudcode commented Jun 7, 2024

Title and Issue number

Title : fixed the page linking problem in PACKAGE.html and addressed the CSS issues in titles and subtitles.

Issue No.: #697

Code Stack : HTML, CSS, JS

Close #697

Description

I have rectified the page linking problem in package.html. Additionally, I addressed slight CSS issues that were causing titles and subtitles to appear off-center and not in their original form. Specifically, I centered the titles and subtitles in both package.html and index.html, making necessary adjustments in styles.css.

Video/Screenshots (mandatory)

package.html now,
image

By clicking 'Book Now' under Maldives and many other places, it showed the error 404, but I have rectified that now
image
image

Center aligned the topics and subtopics in index.html
image
image
image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): ___________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

Are you contributing under any Open-source programme?

yes

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit f072fe6
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66634b1376c69a000856fc83
😎 Deploy Preview https://deploy-preview-803--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thecloudcode! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@thecloudcode thecloudcode changed the title thecloudcode : Debugged PACKAGE.html problem #697 fix: Debugged PACKAGE.html problem #697 Jun 7, 2024
@thecloudcode
Copy link
Author

Hi @apu52 , this PR is ready for review. Kindly, tell me if any further changes are required.

This is my first contribution to GSSoC'24. Kindly, merge it or suggest me more changes 🙏

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thecloudcode this PR has merge conflicts .please try to solve the merge conflicts .
As u are a beginner in open Source , I want first to say welcome & congratulations on being selected for GSSOC.
& also want to suggest you to close this PR & Submit a new PR(making a new branch in the forked repo & push all of your changes there ) so that u will be able to avoid conflicts

@apu52 apu52 added the help wanted Extra attention is needed label Jun 26, 2024
@thecloudcode
Copy link
Author

Sure @apu52 I will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG : PACKAGE.html problem
2 participants