Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the alignment issue for toggle button #984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChiragShukla222
Copy link

@ChiragShukla222 ChiragShukla222 commented Jul 15, 2024

[Bug]: Dark and light mode alignment issue #941

Title :
[Bug]: Dark and light mode alignment issue
Issue No. :
#941

Close #941

Code Stack :

Close #<941>

Video (mandatory)

[

index.html.-.METAVERSE.-.Visual.Studio.Code.2024-07-15.15-18-46.mp4

](url)

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have gone through the contributing.md file before contributing

Additional context (Mandatory )

Are you contributing under any Open-source programme?

  • I'm a GSSOC'24 contributor

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for cute-quokka-b093d8 ready!

Name Link
🔨 Latest commit c220734
🔍 Latest deploy log https://app.netlify.com/sites/cute-quokka-b093d8/deploys/6694f118ddf85400094debef
😎 Deploy Preview https://deploy-preview-984--cute-quokka-b093d8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiragShukla222 the changes u have made are really good .but I still like the custom design of the toggle button which we already have in the website & I much not like the deign of this PR .
But this issue is still open , if u have farther more good ideas about the toggle button u can submit a new PR on it.

@apu52 apu52 added wontfix This will not be worked on changesrequested labels Jul 15, 2024
@ChiragShukla222
Copy link
Author

Hi @apu52 ,

Thank you for your feedback on the toggle button design. I appreciate your input and understand the importance of maintaining consistency with the existing website design.I’m open to further discussions and iterations to ensure we achieve the best possible outcome for the project. If you have any specific aspects of the current toggle button design that you’d like to retain, I would be happy to integrate those elements into the new pr.

@apu52
Copy link
Owner

apu52 commented Jul 15, 2024

Hi @apu52 ,

Thank you for your feedback on the toggle button design. I appreciate your input and understand the importance of maintaining consistency with the existing website design.I’m open to further discussions and iterations to ensure we achieve the best possible outcome for the project. If you have any specific aspects of the current toggle button design that you’d like to retain, I would be happy to integrate those elements into the new pr.

I can suggest u some UI design of the toggle button . but I just want to u can provide me here some of the other designs u have matching with the website

@ChiragShukla222
Copy link
Author

sure we can work on that, we'll provide you with the designs as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesrequested wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dark and light mode alignment issue
2 participants