Fix subdomain name expiration for primary names #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maykonmichel
approved these changes
Nov 13, 2024
davidiw
approved these changes
Nov 14, 2024
| @@ -715,7 +715,7 @@ module aptos_names_v2_1::v2_1_domains { | |||
| /// Returns the reverse lookup (the token addr) for an address if any. | |||
| public fun get_reverse_lookup( | |||
There was a problem hiding this comment.
could probably be a view function...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Primary names will expire if the name itself is expired. Previously, the expiration logic only looked at the record's expiration timestamp, ignoring cases where there was a subdomain policy to follow the domain's expiration. This PR fixes that
Test Plan
Add a test that checks the exact scenario described above