Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owner check to get_primary_name #188

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Add owner check to get_primary_name #188

merged 5 commits into from
Oct 2, 2024

Conversation

BriungRi
Copy link
Contributor

@BriungRi BriungRi commented Aug 5, 2024

This PR addresses the scenario where:

  1. user1 registers name.apt and sets it as primary name
  2. name.apt expires
  3. user2 registers name.apt and sets it as primary name

Now, the only address that has name.apt as primary name should be user2
  

  • Add unit test for updated logic
  • Also fix some older tests

@BriungRi BriungRi merged commit a9d5f36 into main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants