Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev tooling #1384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aol-nnov
Copy link
Contributor

  • Add vscode recommended config and plugins
  • Update docker machinery
  • Simplify Makefile, eliminate the need of editing to enable CAPTURE for new tests. Now simply make (docker-)system-test CAPTURE=yes

Previously created docker stuff did not work (at
least in Dokcer Desktop for Mac). Let's try and
create something more generalzied. Yet, changes
were not tested on WSL.

* Add vscode recommended config and plugins
* Update docker machinery
* Simplify Makefile, eliminate the need of editing to
  enable CAPTURE for new tests. Now simply `make
  (docker-)system-test CAPTURE=yes`

Previously created docker stuff did not work (at
least in Dokcer Desktop for Mac). Let's try and
create something more generalzied. Yet, changes
were not tested on WSL.
@aol-nnov
Copy link
Contributor Author

aol-nnov commented Oct 24, 2024

Code snippet

usermod -u `stat -c %u /work/src` aptly

mentioned in system/docker-wrapper did not work as expected on Docker Desktop for Mac (attached volume mount point is owned by root). Which leads to

$ make docker-image
[+] Building 310.3s (21/21) FINISHED
$ make docker-system-test
usermod: UID '0' already exists
make: *** [docker-system-test] Error 4
$ _

So, let's incorporate developer's UID and GID into image at build time.

N.B.: image is now "developer machine"-specific. Which is of no harm, I suppose, as it is only used for local development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant