Fix race condition with async API operations #1377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolynx
force-pushed
the
fix/concurrent-repo-add
branch
4 times, most recently
from
d813fef to
309450d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/allow_component_management #1377 +/- ##
=====================================================================
Coverage ? 74.91%
=====================================================================
Files ? 156
Lines ? 17970
Branches ? 0
=====================================================================
Hits ? 13462
Misses ? 3419
Partials ? 1089 ☔ View full report in Codecov by Sentry. |
neolynx
changed the base branch from
master
to
feature/allow_component_management
neolynx
changed the title
To achieve feature parity with cli, it is now possible to create repos from snapshots
Update create repo API to support snapshots
This commit allows to add, remove and update components of published repositories without the need to recreate them. Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Do all relevant database reading/modifying inside `maybeRunTaskInBackground`. Notably, `LoadComplete` will load the reflist of a repo. if this is done outside of a background operation, the data might be outdated when the background tasks runs.
neolynx
force-pushed
the
fix/concurrent-repo-add
branch
from
309450d to
92eebba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1376
Description of the Change
maybeRunTaskInBackground.LoadCompletewill load the reflist of a repo. if this is done outside of a background operation, the data might be outdated when the background tasks runs.