Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add a new component to a published repo #1341

Merged

Conversation

cfiehe
Copy link

@cfiehe cfiehe commented Sep 20, 2024

Fixes #832, #1242

Description of the Change

This commit modifies the behavior of the publish switch method in the way, that also new components can be added to an already published repository. It is no longer necessary to drop and recreate the whole publish.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@cfiehe cfiehe force-pushed the allow_add_component_to_publish_switch branch 8 times, most recently from c6c6c0d to 603ad6d Compare September 20, 2024 13:17
@neolynx neolynx added the needs review Ready for review & merge label Sep 20, 2024
@neolynx neolynx requested a review from a team September 20, 2024 14:51
@neolynx
Copy link
Member

neolynx commented Sep 20, 2024

what a great feature to have :-) thanks a lot !

the feature/debian branch is moving to go 1.22, so I would merge this one afterwards...

@neolynx neolynx self-assigned this Sep 20, 2024
@cfiehe cfiehe force-pushed the allow_add_component_to_publish_switch branch from 603ad6d to 609af87 Compare September 20, 2024 14:55
Copy link
Member

@neolynx neolynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@neolynx
Copy link
Member

neolynx commented Sep 24, 2024

please rebase ! then we can merge...

This commit modifies the behavior of the publish switch method in the way, that also new components can be added to an already published repository. It is no longer necessary to drop and recreate the whole publish.

Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
@neolynx neolynx force-pushed the allow_add_component_to_publish_switch branch from 7cf7d11 to d1168d6 Compare September 24, 2024 13:17
@neolynx
Copy link
Member

neolynx commented Sep 24, 2024

I rebased and force pushed to your branch (since it allowed me to do that :-) ...

@neolynx neolynx merged commit 4195ad9 into aptly-dev:master Sep 24, 2024
41 checks passed
@cfiehe
Copy link
Author

cfiehe commented Sep 25, 2024

@neolynx
Cool. Thank you very much for merging this pull request ❤️.

@neolynx
Copy link
Member

neolynx commented Sep 25, 2024

See #1345 for the new APT repos containing a CI build with this change!

@cfiehe
Copy link
Author

cfiehe commented Sep 25, 2024

That are really great news 😃. Thank you very much for all your efforts spent so far for improving, fixing, enhancing and getting Aptly back to life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Ready for review & merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support adding a new component to an existing published repo
2 participants