Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github CI: nightly builds for multiple distributions #1270

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 11, 2024

Fixes #1251

Description of the Change

Since the pipeline changed to use ubuntu22.04 runners, the nighty debian packages do not work on debian buster anymore.
This change updates the pipeline to build for Ubuntu 20.04 and 22.04 as well as for
Debian 10, 11 and 12.

The distribution specific apt sources are as follows:

  "deb http://repo.aptly.info/nightly-bookworm bookworm main"

(replace bookworm with focal, buster, bullseye. Install aptly repo key with: curl -fsS https://www.aptly.info/pubkey.txt | sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/aptly.gpg)

The builds on focal will also release to the legacy nightly apt repo: https://github.com/aptly-dev/aptly/actions/runs/8723898496/job/23933824692#step:7:24

This only affects nightly builds, for now.
Pipeline example: [](https://github.com/aptly-dev/aptly/actions/runs/8723898496)

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (3a29e08) to head (da9933d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1270       +/-   ##
===========================================
+ Coverage        0   74.70%   +74.70%     
===========================================
  Files           0      144      +144     
  Lines           0    16216    +16216     
===========================================
+ Hits            0    12114    +12114     
- Misses          0     3158     +3158     
- Partials        0      944      +944     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx force-pushed the feature/build-dists branch 18 times, most recently from d3f9d27 to f272d42 Compare April 17, 2024 15:10
@neolynx neolynx changed the title build for focal and jammy github CI: build for multiple distributions Apr 17, 2024
@neolynx neolynx self-assigned this Apr 17, 2024
@neolynx neolynx requested a review from a team April 17, 2024 15:13
@neolynx neolynx changed the title github CI: build for multiple distributions github CI: nightly builds for multiple distributions Apr 17, 2024
    Since the pipeline changed to use ucuntu22.04 runners, the nighty debian packages do not work on debian buster anymore.
    This change updates the pipeline to build for Ubuntu 20.04 and 22.04 as well as for
    Debian 10, 11 and 12.

    The distribution specific apt sources are as follows:

      "deb http://repo.aptly.info/nightly-bookworm bookworm main"

    (replace bookworm with focal, buster, bullseye. Install aptly repo key with: curl -fsS https://www.aptly.info/pubkey.txt | sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/aptly.gpg)

    The builds on focal will also release to the legacy nightly apt repo: https://github.com/aptly-dev/aptly/actions/runs/8723898496/job/23933824692#step:7:24

    This only affects nightly builds, for now.
    Pipeline example: [](https://github.com/aptly-dev/aptly/actions/runs/8723898496)
curl -fsS -X DELETE -u $aptly_user:$aptly_password ${aptly_api}/api/files/$folder
echo
}
trap cleanup EXIT
Copy link

@szakalboss szakalboss Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna trap also INT and TERM ? (eg system reboot...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both result in EXIT

@neolynx neolynx merged commit f233a21 into master Apr 17, 2024
9 checks passed
@neolynx neolynx deleted the feature/build-dists branch April 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly version for Debian/Ubuntu requires GLIBC_2.32 since the latest version
2 participants