Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 api: get publish root list #1247

Merged
merged 1 commit into from
Apr 3, 2024
Merged

s3 api: get publish root list #1247

merged 1 commit into from
Apr 3, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Feb 6, 2024

Description of the Change

allow to query the available s3 buckets, so the information can be used by subsequent api calls.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx requested a review from a team February 6, 2024 20:40
@neolynx neolynx self-assigned this Feb 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.76%. Comparing base (e564b7c) to head (2b61c40).

Files Patch % Lines
api/s3.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
- Coverage   74.78%   74.76%   -0.03%     
==========================================
  Files         143      144       +1     
  Lines       16200    16209       +9     
==========================================
+ Hits        12115    12118       +3     
- Misses       3148     3154       +6     
  Partials      937      937              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mfolusiak mfolusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with the default config from aptly(1)

@neolynx neolynx merged commit b5b0a52 into master Apr 3, 2024
4 of 5 checks passed
@neolynx neolynx deleted the feature/s3-endpoint-api branch April 6, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants