-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Improve build.yml #60
Conversation
- Change fetch-depth to 0 in release job - Release job enabled only on the default branch - Kover skipped on fork PRs
WalkthroughThe updates to the GitHub Actions workflow enhance the build process by adding more precise conditions for job execution and improving the checkout step's depth handling. These changes ensure that jobs only run on the default branch and for a specific repository, while also fetching the complete history during the checkout. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Branch Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build.yml (2 hunks)
Additional comments not posted (3)
.github/workflows/build.yml (3)
73-73
: Conditionally run the release job on the default branch with a non-SNAPSHOT version.This condition ensures that the release job only runs on the default branch, during a manual dispatch event, and with a valid release version. This is a good practice to prevent accidental releases from non-default branches or with invalid versions.
76-77
: Ensure full history is fetched for the release job.Adding
fetch-depth: 0
ensures that the entire Git history is fetched, which is necessary for creating accurate release tags and changelogs.
97-97
: Conditionally run the kover job for pull requests in the main repository.This condition ensures that the kover job only runs for pull requests in the main repository, preventing unnecessary runs on forked repositories. This is a good practice to save resources.
Line Coverage
|
Summary by CodeRabbit