Fix device model identifier for Mac #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uname` returns x86_64 (or Apple Silicon equivalent) for Macs. Get the device name in another way for Mac devices. If it fails, fallback to the default way (can be represented as "unknown Mac" or similar).
|
@goenning With this fix I think all supported platforms should now report a device model corresponding to the actual device the code is running on. FWIW the method used is similar to how other popular libraries (Firebase) gather the identifier. Fine to merge? |
|
Thanks @manucheri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unamereturnsx86_64(or Apple Silicon equivalent) as the device name for Macs. Get the device name in another way for Mac devices. If it fails (it shouldn't AFAIK but still), fallback to the default way (which I guess can be represented as "unknown Mac" or similar).