Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks #15

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Small tweaks #15

merged 3 commits into from
Oct 11, 2023

Conversation

manucheri
Copy link
Contributor

@manucheri manucheri commented Oct 11, 2023 •
edited
Loading

Some various small tweaks:

  • Remove workaround to add the DocC dependency before when Swift 5.5 was supported.
  • Update package file to show that only Swift 5.7 and higher is supported.
  • Small tweak to the README.

@manucheri
Directly add DocC dependency in package file
9ccf7cf 
Since the package now only supports Swift 5.6 and higher we don't
need to check before adding the DocC dependency.
@manucheri
Update README
8dd9065 
Just a small change to show the latest app version in the example.
@manucheri
Update Swift version
08118b1 
Since 5.6 support was previously dropped, updating the package files
to reflect that.
@goenning goenning merged commit 5226af5 into aptabase:main Oct 11, 2023
4 checks passed
@goenning
Copy link
Member

Thank you!

Have you tried the new version with batching? Is it working well?

@manucheri
Copy link
Contributor Author

Thank you!

Have you tried the new version with batching? Is it working well?

Have recently updated to it, have not seen any issues but my use case is quite simple. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manucheri @goenning