Fix issue #86 and issue #103 combined #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a_field_to_fr_field
…x issue apryor6#86. Implemented test utils_test.test_unpack_nested_many as well.
|
I just realised it crashes at some point with flask restx . I'll add additional testing. Sorry. #86 should be fine though. |
|
Ok, my bad - it was an error in my test-application. If you like I can also upload some short test-app. |
|
Can't wait for it to be merged. It sucks to make it by hands for every new environment. |
|
Thank @Wormfriend for the fixes. Had the same issue after an upgrade and the proposed fixes worked well, waiting for the merge. |
|
Apologies for the delay and thanks! This is now available on 0.18.2 on PyPi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combined proposed fix for the issues #86 and #103. for #86 I implemented a conditional within unpack_nested checking for many=True and if wrapping fr.Nested into a fr.List as in unpack_nested_self. For #103 I added type-checking for ma.utils._Missing. Thank you for your work!