fix: error early when the image write fails (#34)

Closes #33
apricote · Jun 23, 2024 · 256989f · 256989f
1 parent 8347e4e
commit 256989f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/hcloudimages/client.go b/hcloudimages/client.go
@@ -299,6 +299,10 @@ func (s *Client) Upload(ctx context.Context, options UploadOptions) (*hcloud.Ima
 	}
 
 	cmd += "dd of=/dev/sda bs=4M && sync"
+
+	// Make sure that we fail early, ie. if the image url does not work.
+	// the pipefail does not work correctly without wrapping in bash.
+	cmd = fmt.Sprintf("bash -c 'set -euo pipefail && %s'", cmd)
 	logger.DebugContext(ctx, "running download, decompress and write to disk command", "cmd", cmd)
 
 	output, err := sshsession.Run(sshClient, cmd, options.ImageReader)