Skip to content

Commit

Permalink
Merge pull request #13 from appventure-nush/beta
Browse files Browse the repository at this point in the history
Fixes for plotly
  • Loading branch information
squi-ddy authored Sep 19, 2023
2 parents 1d73f8d + c31a548 commit 9cf2385
Show file tree
Hide file tree
Showing 6 changed files with 83 additions and 6 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/beta.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Push to Registry (Beta Build)

on:
push:
branches:
- beta

jobs:
build:

runs-on: ubuntu-latest


steps:
- uses: actions/checkout@v2
- name: Push image to AppVenture registry
uses: docker/build-push-action@v1
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
registry: registry.nush.app
repository: e-notes
tags: beta
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Node.js CI
name: Push to Registry

on:
push:
Expand Down
7 changes: 5 additions & 2 deletions frontend/src/components/notebookViewer/BlockOutput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<v-col cols="12" v-if="graphic" class="cell-content output-display">
<img v-if="'image/png' in output.data" alt="Image Error"
:src="b64ToUrl(normaliseJupyterOutput(output.data['image/png']),'image/png')"/>
<div v-if="'text/html' in output.data" v-html="output.data['text/html'].join('')"></div>
<HTMLOutput v-if="'text/html' in output.data" :html="output.data['text/html'].join('')" />
</v-col>
</template>
<pre v-else-if="output.output_type==='error'" class="cell-content output-err"
Expand All @@ -42,9 +42,12 @@
import {Component, Prop, Vue} from "vue-property-decorator";
import {Cell} from "@/types/shims/shims-nbformat-v4";
import Convert from "ansi-to-html";
import HTMLOutput from "@/components/notebookViewer/HTMLOutput.vue";
const convert = new Convert();
@Component
@Component({
components: {HTMLOutput}
})
export default class BlockOutput extends Vue {
name = "BlockOutput"
@Prop(Object) readonly cell!: Cell;
Expand Down
45 changes: 45 additions & 0 deletions frontend/src/components/notebookViewer/HTMLOutput.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<template>
<div v-html="html" ref="htmlDiv"></div>
</template>

<script lang="ts">
import {Component, Prop, Vue} from "vue-property-decorator";
@Component
export default class HTMLOutput extends Vue {
name = "HTMLOutput"
@Prop(String) readonly html!: string;
createScript(node: HTMLScriptElement) {
var script = document.createElement("script");
script.text = node.innerHTML;
for (var i=0; i < node.attributes.length; i++) {
var attr = node.attributes[i];
script.setAttribute(attr.name, attr.value);
}
return script;
}
recurseDescendants (node: Element) {
for (var i = 0; i < node.children.length; i++) {
var child = node.children[i];
this.recurseDescendants(child);
if (child.tagName === 'SCRIPT') {
node.replaceChild(this.createScript(child as HTMLScriptElement), child);
}
}
}
mounted() {
console.log("running scripts");
this.$nextTick(() => {
this.recurseDescendants(this.$refs.htmlDiv as Element);
});
}
}
</script>

<style scoped>
</style>
8 changes: 5 additions & 3 deletions frontend/src/mixins/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,9 @@ export function addPyScript() {
if (!document.getElementById('pyscript')) {
const env = document.createElement('py-env');
env.innerHTML = `
- numpy
- matplotlib`
- numpy
- matplotlib
`
document.head.appendChild(env);
const script = document.createElement('script');
script.id = 'pyscript';
Expand All @@ -132,11 +133,12 @@ export function addPyScript() {
document.head.appendChild(script);
const styles = document.createElement('style');
styles.innerHTML = `
.v-application.theme--dark .editor-box .cm-gutters{
.v-application.theme--dark .editor-box .cm-gutters {
background-color: #999;
color: #f5f5f5;
}
`
document.head.appendChild(styles);
}
}

Expand Down
4 changes: 4 additions & 0 deletions frontend/src/pages/Index/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -321,4 +321,8 @@ body.rb.rb-lock-off {
}
}
py-loader, py-terminal {
display: none;
}
</style>

0 comments on commit 9cf2385

Please sign in to comment.