Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #18 - NPE with Array generator #19

Merged
merged 3 commits into from
Oct 22, 2017
Merged

Conversation

ymohdriz
Copy link
Contributor

@djodjoni

Hi,

First of all, thanks for this project. Its really useful for my project.
I have fixed the NPE when minItems, maxItems is not set in the json schema when the type is 'array'.
Detailed issue description: #17

I request you to do the code review and inform me if any changes are required.

Thanks,
Mohammed Rizwan

@Malligarjunan
Copy link

@djodjoni - Any idea when this fix can be merged?

Copy link

@Malligarjunan Malligarjunan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks Good. Could someone merge the changes?

@djodjoni djodjoni merged commit c90f0dd into apptik:master Oct 22, 2017
@djodjoni
Copy link
Member

Hey @Malligarjunan ! Thank you for the input! I will make a new release in the next days !

@rvenkateshkumar86-cts
Copy link

@djodjoni Latest jar available in maven doesnt have fix for NPE for arraygenerator as per issue #18. can you please share latest jar for NPE with ArrayGenerator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants