Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:delete unused files #36368

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore:delete unused files #36368

merged 1 commit into from
Sep 19, 2024

Conversation

KelvinOm
Copy link
Collaborator

@KelvinOm KelvinOm commented Sep 17, 2024 •
edited by github-actions bot
Loading

Description

I used knip to identify unused files. There will be a few more related PRs, after that I will add CI check for this.

Fixes #35778

Related EE PR https://github.com/appsmithorg/appsmith-ee/pull/5165

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10940962461
Commit: 3174957
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Thu, 19 Sep 2024 12:55:41 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024 •
edited
Loading

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

74 files out of 156 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 17, 2024
ankitakinger
ankitakinger previously approved these changes Sep 17, 2024
View reviewed changes
@KelvinOm KelvinOm added the ok-to-test Required label for CI label Sep 17, 2024
@github-actions github-actions bot added Anvil Pod Issue related to Anvil project Task A simple Todo labels Sep 17, 2024
@KelvinOm KelvinOm added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 17, 2024
ApekshaBhosale
ApekshaBhosale previously approved these changes Sep 17, 2024
View reviewed changes
@ApekshaBhosale ApekshaBhosale added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 17, 2024
ayushpahwa
ayushpahwa previously approved these changes Sep 18, 2024
View reviewed changes
@hetunandu hetunandu added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 18, 2024
@nidhi-nair nidhi-nair removed the request for review from a team September 18, 2024 06:05
@albinAppsmith
Copy link
Collaborator

/build-deploy-preview skip-test=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10917454151.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 36368.
recreate: .

hetunandu
hetunandu requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@hetunandu hetunandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many files that are in experimental stages hence still kept around like the IDE files

There are many files that are used / imported in EE so cannot be deleted

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-36368.dp.appsmith.com

@KelvinOm
Copy link
Collaborator Author

There are many files that are in experimental stages hence still kept around like the IDE files

The project should not contain files that are not used anywhere, since their work cannot even be checked. This is especially important now when we are planning large-scale changes in the project. You can always put files under the feature flag and use theme somewhere or find them in the git even if they have been deleted. It's not a issue.

There are many files that are used / imported in EE so cannot be deleted

Only three files were used in EE and I moved them.

  • app/client/src/ee/pages/AdminSettings/FormGroup/TextAreaField.tsx
  • app/client/src/ee/pages/Editor/AppSettingsPane/PaneHeader.tsx
  • app/client/src/ee/pages/common/AvatarComponent.tsx

@KelvinOm KelvinOm added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 18, 2024
hetunandu
hetunandu previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@hetunandu hetunandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked again and LGTM

@KelvinOm KelvinOm added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 18, 2024
@KelvinOm KelvinOm added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 19, 2024
@KelvinOm KelvinOm merged commit c76e6c0 into release Sep 19, 2024
57 of 64 checks passed
@KelvinOm KelvinOm deleted the chore/delete-unused-files branch September 19, 2024 13:01
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
@KelvinOm @Shivam-z
chore:delete unused files (appsmithorg#36368)
74cfdb7 
## Description
I used [knip](https://knip.dev/) to identify unused files. There will be
a few more related PRs, after that I will add CI check for this.

Fixes appsmithorg#35778

Related EE PR https://github.com/appsmithorg/appsmith-ee/pull/5165

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10940962461>
> Commit: 3174957
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10940962461&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 19 Sep 2024 12:55:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApekshaBhosale ApekshaBhosale ApekshaBhosale left review comments

@ayushpahwa ayushpahwa ayushpahwa left review comments

@hetunandu hetunandu hetunandu left review comments

@ankitakinger ankitakinger ankitakinger left review comments

@sagar-qa007 sagar-qa007 Awaiting requested review from sagar-qa007

Assignees
No one assigned
Labels
Anvil Pod Issue related to Anvil project ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete dead code
6 participants
@KelvinOm @albinAppsmith @ApekshaBhosale @ayushpahwa @hetunandu @ankitakinger