Clean up discarded response message content on the service side #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
reviewed
Aug 11, 2023
| @Override | ||
| public void onExchangeFinally() { | ||
| if (requestMetaData != null && responseMetaData != null) { | ||
| Boolean subscribed = requestMetaData.context().get(payloadSubscribedKey); |
There was a problem hiding this comment.
if a retry occurs the request context map state will be shared, do we reset this state anywhere?
There was a problem hiding this comment.
That's a great question. Can you help me understand / simulate a case where a retry would happen on the Service side during the response flow in the filters?
I added a test for a pure "error" case as well, but I think what you are suggesting is slightly different.
There was a problem hiding this comment.
ah server side retries are less likely but in principal could be done by inserting a filter that has a fallback to in-memory publisher if failure occurs.
There was a problem hiding this comment.
Added a test in the latest changeset.
idelpivnitskiy
requested changes
Aug 15, 2023
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/DefaultHttpServerBuilder.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/DefaultHttpServerBuilder.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/HttpPayloadDiscardWatchdogServiceFilter.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/HttpPayloadDiscardWatchdogServiceFilter.java
Outdated
Show resolved
Hide resolved
...tp-netty/src/main/java/io/servicetalk/http/netty/HttpPayloadDiscardCleanerServiceFilter.java
Outdated
Show resolved
Hide resolved
...ttp-netty/src/test/java/io/servicetalk/http/netty/HttpServicePayloadDiscardWatchdogTest.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/HttpPayloadDiscardWatchdogServiceFilter.java
Outdated
Show resolved
Hide resolved
...ttp-netty/src/test/java/io/servicetalk/http/netty/HttpServicePayloadDiscardWatchdogTest.java
Outdated
Show resolved
Hide resolved
...ttp-netty/src/test/java/io/servicetalk/http/netty/HttpServicePayloadDiscardWatchdogTest.java
Outdated
Show resolved
Hide resolved
...ttp-netty/src/test/java/io/servicetalk/http/netty/HttpServicePayloadDiscardWatchdogTest.java
Outdated
Show resolved
Hide resolved
daschl
changed the title
...c/main/java/io/servicetalk/http/netty/HttpMessageDiscardCleanerServiceLifecycleObserver.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/HttpMessageDiscardWatchdogServiceFilter.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/HttpMessageDiscardWatchdogServiceFilter.java
Outdated
Show resolved
Hide resolved
...p-netty/src/main/java/io/servicetalk/http/netty/HttpMessageDiscardWatchdogServiceFilter.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/servicetalk/http/netty/HttpMessageDiscardCleanerServiceLifecycleObserver.java
Outdated
Show resolved
Hide resolved
...ttp-netty/src/test/java/io/servicetalk/http/netty/HttpMessageDiscardWatchdogServiceTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.