Address feedback from Idel

apple · Nov 16, 2024 · ee093ac · ee093ac
1 parent 050c0f1
commit ee093ac
Show file tree

Hide file tree

Showing 3 changed files with 127 additions and 86 deletions.
diff --git a/servicetalk-examples/grpc/protoc-options/build.gradle b/servicetalk-examples/grpc/protoc-options/build.gradle
@@ -74,6 +74,7 @@ protobuf {
           outputSubDir = "java"
           // Option to append a suffix to type names to avoid naming collisions with other code generation.
           option 'typeNameSuffix=St'
+          // Option to tell the compiler to exclude all Deprecated fields, types, and methods from the output
           option 'skipDeprecated=true'
         }
       }

diff --git a/servicetalk-grpc-api/src/main/java/io/servicetalk/grpc/api/GrpcRoutes.java b/servicetalk-grpc-api/src/main/java/io/servicetalk/grpc/api/GrpcRoutes.java
@@ -1333,10 +1333,8 @@ protected interface BlockingStreamingRoute<Req, Resp>
          * will be used.
          */
         @Deprecated
-        default void handle(GrpcServiceContext ctx, BlockingIterable<Req> request,  // FIXME: 0.43 - add default impl
-                    GrpcPayloadWriter<Resp> responseWriter) throws Exception {
-            throw new UnsupportedOperationException("This method is not used starting from version 0.42.0");
-        }
+        void handle(GrpcServiceContext ctx, BlockingIterable<Req> request,  // FIXME: 0.43 - add default impl
+                    GrpcPayloadWriter<Resp> responseWriter) throws Exception;
 
         /**
          * Handles the passed {@link Req}.
@@ -1347,8 +1345,10 @@ default void handle(GrpcServiceContext ctx, BlockingIterable<Req> request,  // F
          * The implementation of this method is responsible for calling {@link GrpcPayloadWriter#close()}.
          * @throws Exception If an exception occurs during request processing.
          */
-        void handle(GrpcServiceContext ctx, BlockingIterable<Req> request,
-                    BlockingStreamingGrpcServerResponse<Resp> response) throws Exception;
+        default void handle(GrpcServiceContext ctx, BlockingIterable<Req> request,  // FIXME: 0.43 - remove default impl
+                            BlockingStreamingGrpcServerResponse<Resp> response) throws Exception {
+            handle(ctx, request, response.sendMetaData());
+        }
 
         @Override
         default void close() throws Exception {
@@ -1489,10 +1489,8 @@ protected interface BlockingResponseStreamingRoute<Req, Resp>
          * implementation will be used.
          */
         @Deprecated // FIXME: 0.43 - add default impl
-        default void handle(GrpcServiceContext ctx, Req request, GrpcPayloadWriter<Resp> responseWriter)
-                throws Exception {
-            throw new UnsupportedOperationException("This method is not used starting from version 0.42.0");
-        }
+        void handle(GrpcServiceContext ctx, Req request, GrpcPayloadWriter<Resp> responseWriter)
+                throws Exception;
 
         /**
          * Handles the passed {@link Req}.
@@ -1503,8 +1501,10 @@ default void handle(GrpcServiceContext ctx, Req request, GrpcPayloadWriter<Resp>
          * The implementation of this method is responsible for calling {@link GrpcPayloadWriter#close()}.
          * @throws Exception If an exception occurs during request processing.
          */
-        void handle(GrpcServiceContext ctx, Req request,  // FIXME: 0.43 - remove default impl
-                    BlockingStreamingGrpcServerResponse<Resp> response) throws Exception;
+        default void handle(GrpcServiceContext ctx, Req request,  // FIXME: 0.43 - remove default impl
+                            BlockingStreamingGrpcServerResponse<Resp> response) throws Exception {
+            handle(ctx, request, response.sendMetaData());
+        }
 
         @Override
         default void close() throws Exception {