Skip to content

Commit

Permalink
traffic-resilience-http: discard events after cancel in TrafficManage…
Browse files Browse the repository at this point in the history
…ment (#3091)

Motivation:

We accidentially removed the discardEventsAfterCancel flag in
PR #3085.

Modifications:

Add it back.
  • Loading branch information
bryce-anderson authored Nov 7, 2024
1 parent 8441a20 commit 77a3c51
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ private Single<StreamingHttpResponse> handleAllow(
return Single.succeeded(resp).shareContextOnSubscribe();
})
.liftSync(new BeforeFinallyHttpOperator(
new SignalConsumer(this, ticket, ticketObserver, breaker, startTimeNs)));
new SignalConsumer(this, ticket, ticketObserver, breaker, startTimeNs), true));
}

private Single<StreamingHttpResponse> dryRunHandleAllow(
Expand All @@ -308,7 +308,7 @@ private Single<StreamingHttpResponse> dryRunHandleAllow(
}
return resp;
})
.liftSync(new BeforeFinallyHttpOperator(signalConsumer));
.liftSync(new BeforeFinallyHttpOperator(signalConsumer, true));
}

private static final class SignalConsumer implements TerminalSignalConsumer {
Expand Down

0 comments on commit 77a3c51

Please sign in to comment.