allow FundtoHirep to compile and link; fix #85 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move definition of TFundtoHirep methods into FundtoHirep.hpp from FundtoHirep.cpp * change U._grid to U.Grid() following changes in Grid * prefix references to Rep::LatticeField with typename to placate compiler * add new macros to allow the last point to be done in envCreateLat, which adds typename to one but not both arguments
|
I've finally been able to log into TeamCity to see what was failing about the Clang build. (I'm not sure if it was an update to TeamCity enabling public access, or if I just didn't notice the "Register" button previously!) 737beec fixes the build with Clang. It now fails to build with Intel, but the error is "configure: error: impossible to compile a minimal Grid program", which I think must be a configuration error? I can't see how I can affect Grid from this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a full blow-by-blow of the issue, its debugging, and the thinking behind the solution, see #85, which this PR resolves.
Summary of changes:
TFundtoHirepmethods intoFundtoHirep.hppfromFundtoHirep.cppTFundtoHirepspecialisations inFundtoHirep.cppU._gridtoU.Grid()following changes in GridRep::LatticeFieldwithtypenameto placate compilerenvCreateLat, which addstypenameto one but not both arguments