Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSPP]Support Kubernetes ConfigMap for Apollo java, golang client #79
[OSPP]Support Kubernetes ConfigMap for Apollo java, golang client #79
Changes from 26 commits
82f7356
e14fd00
562b325
8705ba1
d8c51dd
435df9d
e2c7cd7
73581e9
c52337c
3a22a38
80f6c59
65ce65a
88b1d75
c3fc604
79ae56a
9252a93
82d61d7
2f5ddf6
f95ca86
7438b07
0c66c59
f7ff6d9
84d10fd
41672e6
03aa3ad
74a6b45
b8392ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declare and initialize
propertiesFactory
before use.The
propertiesFactory
object is used to obtain newProperties
instances at lines 151, 234, and 292, but it is never declared or initialized in the class. This will result in aNullPointerException
at runtime. You should declarepropertiesFactory
as a class member and initialize it before using it.To fix this, add the following declaration to the class fields:
And initialize it in the constructor after
configUtil
andkubernetesManager
are initialized: