Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yaml empty list issue #42

Closed
wants to merge 1 commit into from

Conversation

xusida
Copy link

@xusida xusida commented Oct 24, 2023

What's the purpose of this PR

fix:
Include empty list configuration
yaml file causes exception (NPE) to be thrown

Which issue(s) this PR fixes:

Fixes #41

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #42 (b63c0a8) into main (5344bc4) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
- Coverage     68.59%   68.54%   -0.05%     
+ Complexity     1206     1205       -1     
============================================
  Files           171      171              
  Lines          5196     5198       +2     
  Branches        561      562       +1     
============================================
- Hits           3564     3563       -1     
- Misses         1371     1372       +1     
- Partials        261      263       +2     
Files Coverage Δ
...m/ctrip/framework/apollo/util/yaml/YamlParser.java 94.36% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

@xusida xusida closed this Oct 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yaml里配置List<String> aaa= [],解析后变成null而非空字符串列表
1 participant