-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support concurrent loading of Config for different namespaces (#29) #31
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
============================================
- Coverage 68.32% 68.25% -0.08%
+ Complexity 1191 1190 -1
============================================
Files 169 169
Lines 5156 5160 +4
Branches 561 561
============================================
- Hits 3523 3522 -1
- Misses 1369 1371 +2
- Partials 264 267 +3
|
ccc974a
to
78234c3
Compare
I have read the CLA Document and I hereby sign the CLA |
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/ConcurrentConfigManager.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultConfigManager.java
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultConfigManager.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultConfigManager.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultConfigManager.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultConfigManager.java
Outdated
Show resolved
Hide resolved
I think the changes are looking great! Could you also please make sure to update the CHANGES.md? |
All tasks have been completed.🤝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
fix #29
Which issue(s) this PR fixes:
Fixes #29
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.