fix：初始加载失败依旧加入懒加载列表，异步检查流程优化

[qdsordinarydream]

1. 初始加载失败依旧加入懒加载列表

2. 检查到存在通知，需要判断返回的结构做没有值的容错，在异步流程中，没有值的返回是异常的，应该在请求的时候就报错了
   

3. request 函数中，当只有一个节点可用的时候，直接返回，不然会造成客户端最多异常20min（等待下一次服务列表同步）
   

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of apolloConfig being nil by logging a warning before proceeding with SyncAndUpdate.
  • Conditional logic added to prevent updates when apolloConfig.Configurations is empty.
  • Enhanced error handling in RequestRecovery by ensuring node length checks before setting nodes as down.
  • Adjusted test assertions to validate the proper handling of configuration notifications with -1 instead of 0.

[coderabbitai]

Walkthrough

Recent changes involve enhancing error handling and validation within several components, including client.go, client_test.go, async.go, and request.go. The modifications ensure better logging, more robust condition checks, and updated test assertions, promoting better reliability and maintainability.

Changes

File Path	Change Summary
client.go	Logs a warning when apolloConfig is nil before calling SyncAndUpdate, adjusts value for UpdateNotify, and makes cache.UpdateApolloConfig conditional.
client_test.go	Modifies assertions in tests to check for -1 value in GetNotify method of NotificationsMap.
component/remote/async.go	Adds a condition to ensure apolloConfig.Configurations is not empty before updating appConfig notifications.
protocol/http/request.go	Adds a condition to check node length before marking a node as down in RequestRecovery.

Sequence Diagrams

Handling nil apolloConfig in client.go

sequenceDiagram
    participant Client
    participant Logger
    participant SyncAndUpdate
    participant Cache

    Client->>Logger: Log warning (if apolloConfig is nil)
    alt apolloConfig is not nil
        Client->>SyncAndUpdate: Call SyncAndUpdate
    end
    Client->>Cache: Conditionally call UpdateApolloConfig

Loading

Node Length Check in RequestRecovery

sequenceDiagram
    participant RequestRecovery
    participant NodeManager

    RequestRecovery->>NodeManager: Check node length
    alt Node length > 1
        NodeManager->>RequestRecovery: Node set as down
    else
        NodeManager->>RequestRecovery: Return error
    end

Loading

Poem

In the code's soft glow, a change is clear,
Logs and checks bring reliability near.
Warnings and conditions, updates precise,
Tests now align with values concise.
As nodes and configs dance in tight array,
Our code now meets the dawn of a brighter day.
🐇💻✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mergify]

感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (1)

protocol/http/request.go (1)

Line range hint 74-76: Consider specifying MinVersion: tls.VersionTLS13 in the TLS configuration to ensure that only secure TLS versions are used. This enhances security, especially for public-facing applications.

- InsecureSkipVerify: insecureSkipVerify,
+ InsecureSkipVerify: insecureSkipVerify, MinVersion: tls.VersionTLS13

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9660dd0 and f859700.

Files selected for processing (4)

• client.go (2 hunks)
• client_test.go (1 hunks)
• component/remote/async.go (1 hunks)
• protocol/http/request.go (1 hunks)

Additional comments not posted (5)

component/remote/async.go (1)

86-88: The addition of a condition to check if apolloConfig.Configurations is not empty before updating notifications is a good practice. It prevents unnecessary updates and potential errors when there are no configurations to process.

protocol/http/request.go (1)

216-221: The addition of a condition to check the node length before setting a node down in single-node scenarios is a crucial improvement. It prevents erroneous behavior in systems with minimal node setups and enhances the robustness of the network error handling.

client.go (2)

167-168: Logging a warning when apolloConfig is nil is a good practice as it provides visibility into potential issues during configuration synchronization.

---

193-198: Updating the notification ID to -1 when apolloConfig is not present is a critical fix that ensures the system can handle initial load failures more gracefully by allowing for retries or appropriate handling later.

client_test.go (1)

415-415: Adding an assertion to check the GetNotify method of the NotificationsMap for a specific return value in the TestGetConfigAndInitValNil function is a good practice. It ensures that the method behaves as expected when queried with a non-existent key, enhancing the test coverage and robustness of the new error handling logic.

[coveralls]

Pull Request Test Coverage Report for Build 9042914117

Details

• 14 of 15 (93.33%) changed or added relevant lines in 3 files are covered.
• 6 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.3%) to 75.34%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
protocol/http/request.go	4	5	80.0%

Files with Coverage Reduction	New Missed Lines	%
protocol/http/request.go	6	66.67%

Totals
Change from base Build 8956224862:	-0.3%
Covered Lines:	1329
Relevant Lines:	1764

---

💛 - Coveralls

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f859700 and c1728ac.

Files selected for processing (1)

• client_test.go (2 hunks)

Additional comments not posted (2)

client_test.go (2)

377-377: Approved: Added assertion to check notification value.

The added assertion ensures that the notification value is correctly set to -1 when the configuration is updated, which aligns with the PR objective of ensuring fault tolerance.

---

415-415: Approved: Added assertion to check notification value.

The added assertion ensures that the notification value is correctly set to -1 when the configuration is nil, which aligns with the PR objective of ensuring fault tolerance.

[nobodyiam]

是否能补充下该 pr 修复的问题场景？

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.