Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable retry for the SyncWithNamespace #281

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

saltbo
Copy link
Contributor

@saltbo saltbo commented Jul 3, 2023

Fixes #280

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

@zouyx zouyx self-assigned this Jul 26, 2023
@zouyx
Copy link
Member

zouyx commented Jul 26, 2023

是否能提供一下 testcase?

@zouyx zouyx self-requested a review July 26, 2023 01:47
@mergify mergify bot merged commit f1bf7df into apolloconfig:master Jul 26, 2023
3 checks passed
@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 5440999875

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 74.023%

Totals Coverage Status
Change from base Build 4328954728: 0.02%
Covered Lines: 1288
Relevant Lines: 1740

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 5440999875

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 74.023%

Totals Coverage Status
Change from base Build 4328954728: 0.02%
Covered Lines: 1288
Relevant Lines: 1740

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 写了重试逻辑,但是不能配置重试次数,定义了最大重试次数,又给置成了 1
3 participants